Skip to content

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Sep 20, 2025

In case of release, the sources JAR contained classes.

Now, it contains the "notable" (jdk-11) sources, as Java 8 sources are really just a "placeholder" to politely say "we do not work on Java 8" (JDK HttpClient is not available).

Fixes #1595

@cstamas
Copy link
Member Author

cstamas commented Sep 20, 2025

To test:

$ mvn -f maven-resolver-transport-jdk-parent/ clean package -P apache-release

and inspect the sources jar (note clean is currently must until new bnd plugin fix is released and we update to it).

@cstamas cstamas marked this pull request as ready for review September 20, 2025 12:11
@cstamas cstamas marked this pull request as draft September 20, 2025 12:25
@cstamas
Copy link
Member Author

cstamas commented Sep 20, 2025

Not good, sisu index is lost and transport, while classes are there, is "dead". fixed

@cstamas cstamas marked this pull request as ready for review September 20, 2025 15:51
@cstamas
Copy link
Member Author

cstamas commented Sep 20, 2025

@grgrzybek pls recheck

@cstamas cstamas added this to the 2.0.12 milestone Sep 20, 2025
@cstamas
Copy link
Member Author

cstamas commented Sep 22, 2025

@grgrzybek Thanks!

@cstamas cstamas merged commit 6e645ef into apache:master Sep 22, 2025
8 checks passed
@cstamas cstamas deleted the fix-mr-sources branch September 22, 2025 14:13
@github-actions
Copy link

@cstamas Please assign appropriate label to PR according to the type of change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

maven-resolver-transport-jdk source JAR in Maven Central doesn't contain sources

2 participants